fix: remove axios as a dependency and other small build fixes#971
fix: remove axios as a dependency and other small build fixes#971
Conversation
Changed Files
|
There was a problem hiding this comment.
Pull request overview
This PR removes Node/npm runtime requirements tied to Axios and context-aware-config JS artifacts, aligning the build/runtime with running functions inside rustyscript and simplifying Docker/make build steps.
Changes:
- Removed
axiosfrom the rootpackage.jsondevDependencies and deleted thecrates/context_aware_confignpm project + lockfile. - Simplified build pipelines by removing
crates/context_aware_confignpm install/copy steps frommakefileandDockerfileruntime packaging. - Adjusted example container env setup (strip
REDIS_URL) and updated Rust formatting config to edition 2024.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| package.json | Drops axios from devDependencies (but needs lockfile update). |
| makefile | Removes crates/context_aware_config npm install + node_modules staging during backend builds. |
| Dockerfile | Removes runtime-stage Node setup and stops copying target/node_modules into the runtime image. |
| example.Dockerfile | Deletes REDIS_URL from the example .env to disable Redis caching in the demo image. |
| crates/context_aware_config/src/api/context/handlers.rs | Formatting-only refactor of transaction invocation style. |
| crates/context_aware_config/tests/index.js | Removes a standalone JS test script. |
| crates/context_aware_config/package.json | Removes CAC npm dependency manifest. |
| crates/context_aware_config/package-lock.json | Removes CAC npm lockfile. |
| .rustfmt.toml | Updates rustfmt edition to 2024. |
Files not reviewed (1)
- crates/context_aware_config/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "devDependencies": { | ||
| "@tsconfig/node18": "^18.2.4", | ||
| "axios": "^1.11.0", | ||
| "daisyui": "^4.3.1", | ||
| "newman": "git+ssh://git@github.com:knutties/newman.git#feature/newman-dir", | ||
| "tailwindcss": "^3.3.5" |
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughThis pull request removes Node.js dependencies from the build process by deleting the Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: datron <Datron@users.noreply.github.com>
a145017 to
71fbafb
Compare
Problem
Axios dependencies
Solution
Now that functions run inside rustyscript we can skip the initialization of nodeJS and npm in the run stage of our docker build
Summary by CodeRabbit
Release Notes
Chores
Tests
Refactor