Skip to content

fix: remove axios as a dependency and other small build fixes#971

Open
Datron wants to merge 1 commit intomainfrom
remove-axios-dependencies
Open

fix: remove axios as a dependency and other small build fixes#971
Datron wants to merge 1 commit intomainfrom
remove-axios-dependencies

Conversation

@Datron
Copy link
Copy Markdown
Collaborator

@Datron Datron commented Apr 14, 2026

Problem

Axios dependencies

Solution

Now that functions run inside rustyscript we can skip the initialization of nodeJS and npm in the run stage of our docker build

Summary by CodeRabbit

Release Notes

  • Chores

    • Updated Rust edition to 2024 for improved language features and compatibility.
    • Simplified build process by removing Node.js build dependencies from Docker and Makefile configurations.
    • Removed axios dependency from project.
  • Tests

    • Removed Node.js-based test script.
  • Refactor

    • Improved code formatting in database transaction handling.

Copilot AI review requested due to automatic review settings April 14, 2026 11:25
@Datron Datron requested a review from a team as a code owner April 14, 2026 11:25
@semanticdiff-com
Copy link
Copy Markdown

semanticdiff-com bot commented Apr 14, 2026

Review changes with  SemanticDiff

Changed Files
File Status
  crates/context_aware_config/src/api/context/handlers.rs  100% smaller
  package-lock.json  1% smaller
  .rustfmt.toml Unsupported file format
  Dockerfile Unsupported file format
  crates/context_aware_config/package-lock.json  0% smaller
  crates/context_aware_config/package.json  0% smaller
  crates/context_aware_config/tests/index.js  0% smaller
  example.Dockerfile Unsupported file format
  makefile Unsupported file format
  package.json  0% smaller

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes Node/npm runtime requirements tied to Axios and context-aware-config JS artifacts, aligning the build/runtime with running functions inside rustyscript and simplifying Docker/make build steps.

Changes:

  • Removed axios from the root package.json devDependencies and deleted the crates/context_aware_config npm project + lockfile.
  • Simplified build pipelines by removing crates/context_aware_config npm install/copy steps from makefile and Dockerfile runtime packaging.
  • Adjusted example container env setup (strip REDIS_URL) and updated Rust formatting config to edition 2024.

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
package.json Drops axios from devDependencies (but needs lockfile update).
makefile Removes crates/context_aware_config npm install + node_modules staging during backend builds.
Dockerfile Removes runtime-stage Node setup and stops copying target/node_modules into the runtime image.
example.Dockerfile Deletes REDIS_URL from the example .env to disable Redis caching in the demo image.
crates/context_aware_config/src/api/context/handlers.rs Formatting-only refactor of transaction invocation style.
crates/context_aware_config/tests/index.js Removes a standalone JS test script.
crates/context_aware_config/package.json Removes CAC npm dependency manifest.
crates/context_aware_config/package-lock.json Removes CAC npm lockfile.
.rustfmt.toml Updates rustfmt edition to 2024.
Files not reviewed (1)
  • crates/context_aware_config/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread package.json
Comment on lines 16 to 20
"devDependencies": {
"@tsconfig/node18": "^18.2.4",
"axios": "^1.11.0",
"daisyui": "^4.3.1",
"newman": "git+ssh://git@github.com:knutties/newman.git#feature/newman-dir",
"tailwindcss": "^3.3.5"
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 14, 2026

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 2f843447-9a68-4009-88cd-8aeb37179c8d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Walkthrough

This pull request removes Node.js dependencies from the build process by deleting the package.json file in the context_aware_config crate, removing npm-related steps from the Dockerfile and Makefile, updating the Rust edition to 2024 in .rustfmt.toml, and deleting the associated Node-based test file.

Changes

Cohort / File(s) Summary
Build Configuration
.rustfmt.toml, Dockerfile, makefile
Updated Rust edition from 2018 to 2024; removed npm dependency installation and Node.js setup from Docker builder and runtime stages; removed npm ci and node_modules handling from the backend make target.
Node.js Dependencies Removal
crates/context_aware_config/package.json, package.json
Deleted package.json declaring axios and eslint dependencies for context_aware_config crate; removed axios devDependency from root package.json.
Test and Cleanup
crates/context_aware_config/tests/index.js, crates/context_aware_config/src/api/context/handlers.rs
Deleted Node-based test harness file; reformatted transaction binding syntax in handlers (no functional change).
Runtime Environment
example.Dockerfile
Added line to remove REDIS_URL from copied .env file during image build.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested labels

P0

Suggested reviewers

  • ayushjain17
  • sauraww

Poem

🐰 Node is gone, the build is lean,
Rust takes center stage, serene.
Dependencies shed like morning dew,
The pipeline cleaner, faster too! 🚀

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title accurately describes the primary change: removing axios as a dependency and includes related build fixes across multiple files (Dockerfile, Makefile, package.json, and crates).
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch remove-axios-dependencies

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Signed-off-by: datron <Datron@users.noreply.github.com>
@Datron Datron force-pushed the remove-axios-dependencies branch from a145017 to 71fbafb Compare April 15, 2026 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants