Skip to content

Reviewing.#5

Merged
jvachier merged 10 commits intomainfrom
jv/final_review
Jul 16, 2025
Merged

Reviewing.#5
jvachier merged 10 commits intomainfrom
jv/final_review

Conversation

@jvachier
Copy link
Owner

@jvachier jvachier commented Jul 16, 2025

Describe your changes

Provide a clear and concise description of the changes made in this pull request. Include any relevant context or background information.

  • What is the purpose of this pull request?
  • What problem does it solve?
  • What functionality does it add or improve?

Issue ticket number and link

Type of Change

Check the type of change your pull request introduces:

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (code improvements without changing functionality)

Checklist before requesting a review

Before submitting your pull request, ensure the following:

  • I have performed a self-review of my code.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added or updated relevant documentation (if applicable).
  • My changes do not introduce any new warnings or errors.
  • I have checked for security vulnerabilities in the code.
  • I have ensured backward compatibility (if applicable).

@jvachier jvachier self-assigned this Jul 16, 2025
@jvachier jvachier requested a review from Copilot July 16, 2025 13:00

This comment was marked as outdated.

jvachier and others added 3 commits July 16, 2025 15:02
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@jvachier jvachier requested a review from Copilot July 16, 2025 13:10
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

A refactor that centralizes configuration with dataclasses, updates callback and ensemble logic, modernizes slider setup, and bumps project version.

  • Converts prediction callbacks and tests to use PredictionInputs dataclass and varargs for cleaner input handling.
  • Refactors ensemble.py with NoisyEnsembleConfig dataclass and dynamic weight blending in improved_blend_obj.
  • Introduces SliderConfig for UI sliders, updates layout, removes deprecated script entry, and updates docs and version.

Reviewed Changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/dash_app/test_callbacks.py Updated mock callback signature and input validation logic
src/modules/ensemble.py Added NoisyEnsembleConfig, refactored oof_probs_noisy and blending function
pyproject.toml Bumped version, widened dependency bounds, removed personality-demo script
docs/README.md Removed duplicate header
dash_app/dashboard/layout.py Introduced SliderConfig dataclass and updated slider creation
dash_app/dashboard/callbacks.py Added PredictionInputs dataclass and refactored make_prediction
README.md Replaced video embed with markdown image
Comments suppressed due to low confidence (2)

tests/dash_app/test_callbacks.py:174

  • The isinstance(x, int | float) check will raise a TypeError; use isinstance(x, (int, float)) to validate multiple types at runtime.
                if any(not isinstance(x, int | float) for x in inputs if x is not None):

@jvachier jvachier merged commit b7dcaf3 into main Jul 16, 2025
1 check passed
@jvachier jvachier deleted the jv/final_review branch July 16, 2025 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants