Merged
Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
A refactor that centralizes configuration with dataclasses, updates callback and ensemble logic, modernizes slider setup, and bumps project version.
- Converts prediction callbacks and tests to use
PredictionInputsdataclass and varargs for cleaner input handling. - Refactors
ensemble.pywithNoisyEnsembleConfigdataclass and dynamic weight blending inimproved_blend_obj. - Introduces
SliderConfigfor UI sliders, updates layout, removes deprecated script entry, and updates docs and version.
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/dash_app/test_callbacks.py | Updated mock callback signature and input validation logic |
| src/modules/ensemble.py | Added NoisyEnsembleConfig, refactored oof_probs_noisy and blending function |
| pyproject.toml | Bumped version, widened dependency bounds, removed personality-demo script |
| docs/README.md | Removed duplicate header |
| dash_app/dashboard/layout.py | Introduced SliderConfig dataclass and updated slider creation |
| dash_app/dashboard/callbacks.py | Added PredictionInputs dataclass and refactored make_prediction |
| README.md | Replaced video embed with markdown image |
Comments suppressed due to low confidence (2)
tests/dash_app/test_callbacks.py:174
- The
isinstance(x, int | float)check will raise a TypeError; useisinstance(x, (int, float))to validate multiple types at runtime.
if any(not isinstance(x, int | float) for x in inputs if x is not None):
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Provide a clear and concise description of the changes made in this pull request. Include any relevant context or background information.
Issue ticket number and link
Type of Change
Check the type of change your pull request introduces:
Checklist before requesting a review
Before submitting your pull request, ensure the following: