fix: Skip first second of audio to prevent overlap from previous track (#359)#532
Open
Kiki-bo-zhang wants to merge 1 commit intojwallet:masterfrom
Open
fix: Skip first second of audio to prevent overlap from previous track (#359)#532Kiki-bo-zhang wants to merge 1 commit intojwallet:masterfrom
Kiki-bo-zhang wants to merge 1 commit intojwallet:masterfrom
Conversation
jwallet#359) Fix audio overlap issue where songs have audio from the previous track at the beginning. Changes: - Enums/SilenceAnalyzer.cs: Add SkipStart option - AudioSessions/AudioThrottler.cs: Implement SkipStart logic - Skip first 1000ms of buffer when starting new recording - Add SkipStartByteLength calculation - Recorder.cs: Use SilenceAnalyzer.SkipStart when starting recording This implements the same workaround users were doing manually with ffmpeg -ss 0:01 to skip the first second of audio that contains overlap from the previous track. Fixes jwallet#359
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the audio overlap issue (#359) where recorded songs have audio from the previous track at the beginning.
Problem
Users reported that most songs have extra leading silence, and some songs have audio from the previous track at the beginning. The user's workaround was:
This manually skips the first second of audio.
Solution
Implemented automatic skipping of the first 1000ms of audio when starting a new recording:
Changes
Technical Details
Testing
This fix implements the same approach users have been using manually with ffmpeg.
Fixes #359
@jwallet Please review when you have time!
IssueHunt Summary
Referenced issues
This pull request has been submitted to: