Updates gmusicapi again to fix list station errors#20
Open
pablorusso wants to merge 5 commits intojwdempsey:masterfrom
Open
Updates gmusicapi again to fix list station errors#20pablorusso wants to merge 5 commits intojwdempsey:masterfrom
pablorusso wants to merge 5 commits intojwdempsey:masterfrom
Conversation
Update gmusicapi fix login
pycryptodomex-3.4.2 binaries included only for windows. Linux and macOS users will have to rebuild the module and replace it inside Shared folder.
Updates gmusicapi to fix station list
greatwroth
approved these changes
Oct 8, 2016
greatwroth
left a comment
greatwroth
left a comment
There was a problem hiding this comment.
I can confirm working using server version 1.1.4.2757-24ffd60 (latest). Tested playing on PLEX app for Roku TV, most menus and playing works perfectly, only thing not working is search function displays "content unavailable" no matter what is searched. Huge step in the right direction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Web protocol was deprecated by google, so I have updated the gmusicapi and changes gmusic to use only mobileclient.
Also previous update didn't work anymore when listing stations, so this new update fix that too.
The new gmusicapi depends on
pycryptopycryptodomex-3.4.2 which was a PITA to build and use inside a windows plex, but its is working. I had tested it only in a windows server.The trick is to compile it with plex python and
vs2013vs2015 as plex uses a custom python 2.7 build (plexscripthost) that depednds onmsvcrt120msvcrt140 instead of msvcrt90 (like regular python 2.7 does)You can check #13 for more information