Skip to content

Conversation

@winiciusallan
Copy link
Contributor

Happy new year :).

@github-actions github-actions bot added the semver:patch No API change label Jan 7, 2026
@winiciusallan
Copy link
Contributor Author

winiciusallan commented Jan 7, 2026

Ok, I saw that was a discussion here about not using years anymore.

@mandre
Copy link
Collaborator

mandre commented Jan 7, 2026

Ok, I saw that was a discussion here about not using years anymore.

That's right, I had forgotten about it. Next time I'll stick it in an issue so we don't forget.

Would you like to update the patch to drop the year instead? We will need to re-generate the assets with make generate too.

@winiciusallan
Copy link
Contributor Author

Sure, I can go for it. Do you think we need to update the copyright year in README?

https://github.com/k-orc/openstack-resource-controller/?tab=readme-ov-file#license

@mandre
Copy link
Collaborator

mandre commented Jan 7, 2026

Sure, I can go for it. Do you think we need to update the copyright year in README?

https://github.com/k-orc/openstack-resource-controller/?tab=readme-ov-file#license

Probably, yes. And from the scaffolding tool too.

Happy new year :).
@winiciusallan
Copy link
Contributor Author

winiciusallan commented Jan 7, 2026

Probably, yes. And from the scaffolding tool too.

Here it is. Changes:

  • Changed year on README
  • Dropped from the scaffolding tool
  • Dropped from the resource-generator (I wasn't sure about this one, but it seemed to make sense)
  • Ran make generate

@mandre mandre added this pull request to the merge queue Jan 8, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 8, 2026
## License

Copyright 2024.
Copyright 2026.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to note that it would also probably have been fine to drop the date here and use the same copyright as in other files:
Copyright The ORC Authors.

@mandre mandre added this pull request to the merge queue Jan 8, 2026
Merged via the queue into k-orc:main with commit 433af38 Jan 8, 2026
9 checks passed
@winiciusallan winiciusallan deleted the new-year branch January 8, 2026 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver:patch No API change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants