Upgrade Cedar Policy engine from v4.7.0 to v4.8.2 #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Contributor
|
Overall, this looks good to me. Thank you! Can you please:
If you prefer, I can do the above and push to your PR branch if you give me permissions (docs). |
Changes: - Update cedar-policy dependencies to ~4.8.0 in Cargo.toml - Update integration test submodule to v4.8.2 - Update .gitmodules branch to release/4.8.x - Update README version mapping table Breaking change for users of format_policies(): - Cedar 4.8 formatter now outputs dot notation (resource.account) instead of bracket notation (resource["account"]) - Both syntaxes are valid Cedar input; only formatter output changed - Update test expectations to match new formatter output Bug fixes included from Cedar 4.8.x: - Fixed parsing of small negative decimal literals (4.8.1) - Improved error message diagnostics (4.8.2) Testing: - All 51 unit tests pass - All 69 integration tests pass (5 skipped, same as before)
Iamrodos
force-pushed
the
upgrade-cedar-4.8.2
branch
from
dbbe387 to
8c29de4
Compare
Contributor
Author
|
Done. |
Contributor
|
Thank you! The performance looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades Cedar Policy engine from v4.7.0 to v4.8.2.
Closes #36
Changes
Breaking Change
format_policies()output has changed. Cedar 4.8 formatter now outputs dot notation instead of bracket notation:resource["account"]resource.accountresource has "account"resource has accountBoth syntaxes are valid Cedar input - only the formatter output changed. Users comparing or storing formatted policy strings may need to update their expected values.
Bug Fixes from Cedar 4.8.x
Testing