Skip to content

Conversation

@onematchfox
Copy link

Excuse the adjacent changes - have tried to split up commits to make this easier to review 🙏

  • Needed the chunking logic for the new processor, so I decided to start by refactoring that out as I noticed this was repeated everywhere (was slightly different depending on the source)
  • Logging changes were needed because notion-to-md contains very verbose use of console.debug
    • also a bunch of formatting in there 😬
    • there's definitely room for improvement in the implementation still, but I figured I've already changed more than I should, given the intended scope of this PR and the nature of the application itself

"dotenv": "^16.3.1",
"js-yaml": "^4.1.0",
"jsdom": "^26.0.0",
"notion-to-md": "^4.0.0-alpha.7",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Hope the introduction of this is OK. Made my life much easier for an implementation standpoint. Can look at inlining the implementation if folks are against the new dependency.
  2. I chose to use the alpha release to minimise having to rework this codebase since it seems to be relatively close to full release 🤞

@onematchfox onematchfox marked this pull request as ready for review July 30, 2025 16:02
@onematchfox onematchfox changed the title refactor: extract method processAndStoreChunks Add support for Notion database source Jul 30, 2025
@onematchfox onematchfox force-pushed the notion branch 2 times, most recently from 5ba1bd2 to 109d00d Compare August 26, 2025 08:05
Signed-off-by: Brian Fox <878612+onematchfox@users.noreply.github.com>
Signed-off-by: Brian Fox <878612+onematchfox@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants