Improve logging in MCP server #34
Open
+202
−64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onematchfox
force-pushed
the
mcp-logging
branch
from
323da23 to
2830a49
Compare
Contributor
|
Thanks for the PR @onematchfox! can you sign the DCO? |
Signed-off-by: Brian Fox <878612+onematchfox@users.noreply.github.com>
onematchfox
force-pushed
the
mcp-logging
branch
from
2830a49 to
1a093a0
Compare
Author
My bad. Fixed now 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into some issues when trying to use the MCP server, which turned out to be a result of slowness when trying to create embeddings based on the query. Extending the logging in the MCP (using a trimmed-down version of the logger used when generating the databases) to make use of log levels and output timestamps helped in diagnosing the issue.