Skip to content

Conversation

@miguelwhite
Copy link

@miguelwhite miguelwhite commented May 1, 2018

This change is Reviewable

@kakwa
Copy link
Owner

kakwa commented May 18, 2018

Sorry for the delay.

I'm wondering if it would be possible to factorize this part and only make samba::params configurable:

https://github.com/kakwa/puppet-samba/blob/master/manifests/params.pp

if custom packages are needed, just instantiate samba::params with additional parameters. I'm not sure it will work but this module used to do something close when it was handling installation from sernet packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants