Open
Conversation
kashifpk
approved these changes
Jun 20, 2023
Owner
kashifpk
left a comment
kashifpk
left a comment
There was a problem hiding this comment.
This looks better. Please review the comments otherwise this should be stable enough to merge.
| AyaText.new(aya_doc, content.strip(), language, text_name) | ||
|
|
||
| total = 0 | ||
| file_range = len(file.readlines()) |
Owner
There was a problem hiding this comment.
In order to introduce the progress bar, the logic now reads the entire file at the start. The previous logic was meant so even large files don't require big memory overhead because of the program loading the full file. In previous implementation it was just one line at a time that was being read from the file.
Owner
There was a problem hiding this comment.
May be to keep the progress bar and avoid the double for loop below we could do something like:
file_lines = file.readlines()
total_lines = len(file_lines)
with typer.progressbar(range(total_lines)) as progress:
for value in progress:
line = file_lines[value]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.