Skip to content

Conversation

@wagle
Copy link

@wagle wagle commented Jun 8, 2016

I think I fixed the merge conflict.

wagle added 2 commits July 17, 2015 18:13
remove some trailing whitespace
add newline at end of defaults.js
@kashiif
Copy link
Owner

kashiif commented Jun 10, 2016

Thanks for your efforts. I can now see the problem. If "Expand Tree To Show All Bookmarks" option is checked in options dialog, the bookmarks popup does not re-size correctly. It expands horizontally but not vertically.

@wagle
Copy link
Author

wagle commented Jun 10, 2016

Ok, will look into that. It does work reasonably when
extensions.editbookmarkplus.autoExpandTags = true
extensions.editbookmarkplus.autoExpandTree = false

Remaining issue is what to do about changing the relative sizes of the two expanded boxes when the above . You have any ideas? I don't understand the API.

@kashiif
Copy link
Owner

kashiif commented Jun 10, 2016

It does work reasonably when extensions.editbookmarkplus.autoExpandTags =
true and extensions.editbookmarkplus.autoExpandTree = false. So it works
only when one of the preference has a value opposite to other one.

The only problem is when both are true.

About adjusting the relative sizes of two boxes, I have an idea that I need
to try. I will let you know if it works.

Regards,
Kashif Iqbal Khan

On Sat, Jun 11, 2016 at 2:19 AM, Perry Wagle notifications@github.com
wrote:

Ok, will look into that. It does work reasonably when
extensions.editbookmarkplus.autoExpandTags = true
extensions.editbookmarkplus.autoExpandTree = false

Remaining issue is what to do about changing the relative sizes of the two
expanded boxes when the above . You have any ideas? I don't understand the
API.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#10 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ABveTPYaRvrCulCZHpHraD5IJS2_vFISks5qKY6dgaJpZM4Iwp72
.

@wagle
Copy link
Author

wagle commented Aug 23, 2016

Hi —

Any news on including my patch in edit-bookmark-plus?

Thanks!

— Perry

On Jun 10, 2016, at 3:08 PM, Kashif Iqbal Khan notifications@github.com wrote:

It does work reasonably when extensions.editbookmarkplus.autoExpandTags =
true and extensions.editbookmarkplus.autoExpandTree = false. So it works
only when one of the preference has a value opposite to other one.

The only problem is when both are true.

About adjusting the relative sizes of two boxes, I have an idea that I need
to try. I will let you know if it works.

Regards,
Kashif Iqbal Khan

On Sat, Jun 11, 2016 at 2:19 AM, Perry Wagle notifications@github.com
wrote:

Ok, will look into that. It does work reasonably when
extensions.editbookmarkplus.autoExpandTags = true
extensions.editbookmarkplus.autoExpandTree = false

Remaining issue is what to do about changing the relative sizes of the two
expanded boxes when the above . You have any ideas? I don't understand the
API.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#10 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ABveTPYaRvrCulCZHpHraD5IJS2_vFISks5qKY6dgaJpZM4Iwp72
.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub #10 (comment), or mute the thread https://github.com/notifications/unsubscribe/AAJkDL6w5da1i1iM3vv0Mw-FXpf8n_18ks5qKeBggaJpZM4Iwp72.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants