Skip to content

Conversation

@Happi-cat
Copy link

@Happi-cat Happi-cat commented Apr 19, 2018

  • Replaces if-else with switch (ApproximatelyEquals method)
  • Use Flags for FuzzyStringComparisonOptions (major change as it changes argument of the ApproximatelyEquals method)
  • Cleaned unused namespaces
  • Replaced Capitalize with ToLower
  • Dropped Operations.cs (Unused methods inside - probably can be kept)
  • Use float instead of double as there is no need in such precision
  • Added backtracktable struct in order to drop some arguments as they can be done as fields of struct/class
  • Simplified diffferent code constructions (braces, if-else-return, etc)
  • Added editorconfig file

Probably comparison methods (like HammingDistance and etc) can be marked as internal or private as they are used in ApproximatelyEquals and there is no need to do direct calls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant