-
Notifications
You must be signed in to change notification settings - Fork 91
lints clean #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
lints clean #9
Conversation
WalkthroughESLint suppression directives were added to Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes This change consists solely of adding identical ESLint suppression directives. There is no logic modification, behavioral change, or code restructuring—only lint rule suppression annotations applied in two locations within a single test file. Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/__tests__/01.js (1)
113-122: Remove unused variable instead of suppressing the lint rule.The
waitForLoadingvariable is destructured on line 120 but is never used in the test (the only call to it on line 138 is commented out). Rather than suppressing theno-unused-varsrule with an ESLint directive, remove the unused variable from the destructuring.Apply this diff to remove the unused variable:
const { submitButton, resetButton, taglineInput, bioInput, - waitForLoading, getDisplayData, } = renderApp()Then remove the ESLint directive on line 113.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
src/__tests__/01.js(1 hunks)
🔇 Additional comments (1)
src/__tests__/01.js (1)
113-114: Discrepancy between AI summary and actual changes.The AI-generated summary states that ESLint directives were added before both the "failure works" test and the "reset works" test, but the code only shows a change marker (
~) before the "failure works" test (line 113). The "reset works" test (line 105) shows no corresponding changes.Please confirm whether the "reset works" test should also have received an ESLint directive, or if the summary is inaccurate.
kentcdodds
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this. I think I'd just rather remove the unused variable. I also don't like updating the package-lock.json unnecessarily.
kentcdodds
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
| const { | ||
| submitButton, | ||
| resetButton, | ||
| taglineInput, | ||
| bioInput, | ||
| waitForLoading, | ||
| getDisplayData, | ||
| } = renderApp() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| const {submitButton, resetButton, taglineInput, bioInput, getDisplayData} = | |
| renderApp() |
|
Let's also remove the |
passes
npm run lintSummary by CodeRabbit
Note
Update Node engine requirement to >=16 and bump caniuse-lite with metadata changes.
package-lock.jsonto>=16.caniuse-liteto1.0.30001752with updated metadata (license, funding).Written by Cursor Bugbot for commit 5110d19. This will update automatically on new commits. Configure here.