bpf: Free special fields when update [lru_,]percpu_hash maps #10212
+125
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Upstream branch: 4cb4897 |
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
de0745f to
efe6edf
Compare
Author
|
Upstream branch: b54a8e1 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1019940=>bpf-next
branch
from
f834703 to
5ef8cc9
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
efe6edf to
f6af497
Compare
Author
|
Upstream branch: b54a8e1 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1019940=>bpf-next
branch
from
5ef8cc9 to
b742af3
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
f6af497 to
baaa336
Compare
Author
|
Upstream branch: 6f1f4c1 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1019940=>bpf-next
branch
from
b742af3 to
77c5f03
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
baaa336 to
b6555d5
Compare
Author
|
Upstream branch: f8c67d8 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1019940=>bpf-next
branch
from
77c5f03 to
dd2bdc7
Compare
Author
|
Upstream branch: f8c67d8 |
As [lru_,]percpu_hash maps support BPF_KPTR_{REF,PERCPU}, missing
calls to 'bpf_obj_free_fields()' in 'pcpu_copy_value()' could cause the
memory referenced by BPF_KPTR_{REF,PERCPU} fields to be held until the
map gets freed.
Fix this by calling 'bpf_obj_free_fields()' after
'copy_map_value[,_long]()' in 'pcpu_copy_value()'.
Fixes: 65334e6 ("bpf: Support kptrs in percpu hashmap and percpu LRU hashmap")
Signed-off-by: Leon Hwang <leon.hwang@linux.dev>
Acked-by: Yonghong Song <yonghong.song@linux.dev>
…ate [lru_,]percpu_hash maps Add test to verify that updating [lru_,]percpu_hash maps decrements refcount when BPF_KPTR_REF objects are involved. The tests perform the following steps: 1. Call update_elem() to insert an initial value. 2. Use bpf_refcount_acquire() to increment the refcount. 3. Store the node pointer in the map value. 4. Add the node to a linked list. 5. Probe-read the refcount and verify it is *2*. 6. Call update_elem() again to trigger refcount decrement. 7. Probe-read the refcount and verify it is *1*. Signed-off-by: Leon Hwang <leon.hwang@linux.dev> Acked-by: Yonghong Song <yonghong.song@linux.dev>
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1019940=>bpf-next
branch
from
dd2bdc7 to
6a3651e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: bpf: Free special fields when update [lru_,]percpu_hash maps
version: 6
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=1019940