Trigger CI #10228
Open
Trigger CI #10228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement update_prog for bpf_tracing_link_lops to enable BPF_LINK_UPDATE for fentry, fexit, fmod_ret, freplace, and lsm+ links. The type and expected_attach_type of the new program must match the original program and the new program must be compatible with the attachment target. trace_link_mutex protects concurrent update_prog and release operations from racing. bpf_tracing_link_release now clears out tr_link->trampoline to signal to other concurrent link operations that the link is defunct, so it's also necessary to extend the use of trace_link_mutex to bpf_tracing_link_show_fdinfo and bpf_tracing_link_fill_link_info which read tr_link->trampoline. This is similar to other link ops that support update_prog like netns, sock_map, and xdp links which synchronize link ops with a global mutex. Since contention should be low, this should be OK as opposed to adding a per-link mutex. All link operations except bpf_tracing_link_show_fd_info return -ENOLINK if they execute after the link is released. In the case of bpf_tracing_link_show_fd_info, this isn't an option so instead target_obj_id and target_btf_id will be 0 in the seq_printf call. Signed-off-by: Jordan Rife <jordan@jrife.io>
While not directly related to making __bpf_trampoline_link_poke support in-place link program updates, it seemed inconsistent to still update tr->extension_prog if bpf_arch_text_poke fails when the non-BPF_TRAMP_REPLACE code path below walks back any changes to tr if the trampoline update fails. Instead, make sure to not change tr if the operation fails for BPF_TRAMP_REPLACE. Signed-off-by: Jordan Rife <jordan@jrife.io>
jrife
force-pushed
the
jrife/support-tracing-link-update
branch
from
63e53e3 to
d444e26
Compare
Exercise a series of edge cases and happy path scenarios across a gamut of link types (fentry, fmod_ret, fexit, freplace) to test BPF_LINK_UPDATE behavior for tracing links. Signed-off-by: Jordan Rife <jordan@jrife.io>
jrife
force-pushed
the
jrife/support-tracing-link-update
branch
from
d444e26 to
7b54f95
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
b6555d5 to
910d3ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.