bpf: hashtab: fix 32-bit overflow in memory usage calculation #10230
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Upstream branch: f8c67d8 |
Author
|
Upstream branch: f8c67d8 |
The intermediate product value_size * num_possible_cpus() is evaluated in 32-bit arithmetic and only then promoted to 64 bits. On systems with large value_size and many possible CPUs this can overflow and lead to an underestimated memory usage. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: 304849a ("bpf: hashtab memory usage") Cc: stable@vger.kernel.org Suggested-by: Yafang Shao <laoar.shao@gmail.com> Signed-off-by: Alexei Safin <a.safin@rosa.ru> Acked-by: Yafang Shao <laoar.shao@gmail.com>
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1020810=>bpf-next
branch
from
35a97b9 to
cc98301
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: bpf: hashtab: fix 32-bit overflow in memory usage calculation
version: 2
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=1020810