fix: enable Windows cross-compilation #15
Merged
+27
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
syscall.Stat_tusage to platform-specific files (stat_unix.go,stat_windows.go)getFileOwnership()returns0, 0as UID/GID are Unix conceptsContext
The CLI's GoReleaser build was failing when cross-compiling for Windows:
This fix allows the SDK to be cross-compiled for Windows targets.
Test plan
go build ./...passes on UnixGOOS=windows GOARCH=amd64 go build ./...passesgo test ./...passesNote
Makes file ownership retrieval OS-specific to unblock Windows builds.
getFileOwnershipwithstat_unix.go(usessyscall.Stat_t) andstat_windows.go(returns0, 0)cp.goto callgetFileOwnershipwhenArchiveis set and removes directsyscalldependencysyscall.Stat_tbeing undefinedWritten by Cursor Bugbot for commit fd74c45. This will update automatically on new commits. Configure here.