Skip to content

Notify parent frame about kernel status #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rgarcia merged 4 commits into from
Jan 15, 2026
Merged

Notify parent frame about kernel status #117

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
be40f7a
feat: add kernel iframe events and test page
AbdulRashidReshamwala Jan 12, 2026
3127b65
chore: remove playable watcher and add postMessage guards
AbdulRashidReshamwala Jan 14, 2026
9c21668
Merge branch 'main' into main
AbdulRashidReshamwala Jan 14, 2026
147b97b
refactor: safe targetOrigin and error handling in postMessage
AbdulRashidReshamwala Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions images/chromium-headful/client/src/app.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,17 @@
}
}

get parentOrigin() {
try {
if (document.referrer) {
return new URL(document.referrer).origin
}
} catch (e) {
// fallback if referrer is not a valid URL
}
return '*'
}

@Watch('hideControls', { immediate: true })
onHideControls(enabled: boolean) {
if (enabled) {
Expand Down Expand Up @@ -262,6 +273,13 @@
onConnected(value: boolean) {
Copy link
Contributor

@tembo tembo bot Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: the try/catch currently wraps applyQueryResolution() too, so the error message can be misleading (and it can swallow a real resolution bug).

Suggested change
onConnected(value: boolean) {
onConnected(value: boolean) {
if (!value) return
this.applyQueryResolution()
if (window.parent === window) return
try {
const parentOrigin = document.referrer ? new URL(document.referrer).origin : '*'
window.parent.postMessage({ type: 'KERNEL_CONNECTED', connected: true }, parentOrigin)
} catch (e) {
console.error('Failed to post message to parent', e)
}
}

if (value) {
this.applyQueryResolution()
try {
if (window.parent !== window) {
window.parent.postMessage({ type: 'KERNEL_CONNECTED', connected: true }, this.parentOrigin)
}
} catch (e) {
console.error('Failed to post message to parent', e)
}
}
}

Expand Down Expand Up @@ -326,5 +344,26 @@
get connected() {
return this.$accessor.connected
}

get playing() {
return this.$accessor.video.playing
}

@Watch('playing')
onPlaying(value: boolean) {
try {
if (window.parent === window) return

if (value) {
window.parent.postMessage({ type: 'KERNEL_PLAYING', playing: true }, this.parentOrigin)
} else {
window.parent.postMessage({ type: 'KERNEL_PAUSED', playing: false }, this.parentOrigin)
}
} catch (e) {
console.error('Failed to post message to parent', e)
}
}


}
</script>