Major refactor of how sysrepo callbacks is used in confd #1209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattiaswal
force-pushed
the
confd-refactor-callbacks
branch
7 times, most recently
from
9e23bca to
2a22330
Compare
mattiaswal
force-pushed
the
confd-refactor-callbacks
branch
3 times, most recently
from
2966084 to
fd926f5
Compare
…upgrade resides) To verify the bootorder is still valid after that part of the suite has run.
Sysrepo only care about model changes, but we want the system configuration. Therefore add a common callback for all modules and handle dependencies between the modules, if someone should be run before another for example.
mattiaswal
force-pushed
the
confd-refactor-callbacks
branch
from
fd926f5 to
4a59028
Compare
troglobit
requested changes
Oct 30, 2025
There was a problem hiding this comment.
Amazing work on this! I only have a couple of comments, one of which I think needs your attention.
Also, considering the amount of changes in this daemon related to memory handling in particular, and C code in general, I suggest you run Coverity Scan on the branch before we consider merging it.
Sysrepo lack the functionallity for if change in model A also should demand actions of model B. Previous we have handled this by having callbacks for keystore changes in for example infix-services to be able to reconfigure SSH on asymmetric key changes. This commit instead add a pass where dependencies are found and added to the diff.
Not needed anymore, the configuration change is sequential in change_cb.
mattiaswal
force-pushed
the
confd-refactor-callbacks
branch
from
4a59028 to
98b30d7
Compare
|
Coverity Last Build Status: In-queue. Your build is in the queue to be analyzed. There are 93 builds ahead of it. |
troglobit
approved these changes
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of having separate callbacks for each model, use one callback.
This allows us to handle dependencies between models in a controlled way,
Adding dependencies to the diff, before running the real change "callbacks".
Also fix some minor bugs.
Most likely fixes #855
Description
Checklist
Tick relevant boxes, this PR is-a or has-a: