Skip to content

Conversation

@chrisys
Copy link

@chrisys chrisys commented Feb 20, 2019

No description provided.

@chrisys
Copy link
Author

chrisys commented Nov 11, 2019

@kersing is there any reason why this can't be merged?

@kersing
Copy link
Owner

kersing commented Nov 11, 2019

Didn’t see a notification so I wasn’t aware there was a pull request.

Requests:

  1. Make the index configurable with a sane default if not defined. Preferably by reading from an environment variable. Check libloragw/src/loragw_spi.native.c SPI_SPEED for an example.
  2. Please don’t submit patches with whitespace changes, now I have to check many lines that aren’t real changes. If you want to remove whitespace, make it a separate commit that I can glance over.

@chrisys
Copy link
Author

chrisys commented Nov 21, 2019

@kersing I've addressed those points - let me know if that's acceptable now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants