Skip to content

Conversation

@kevinpapst
Copy link
Owner

@kevinpapst kevinpapst commented Nov 17, 2025

@kevinpapst
Copy link
Owner Author

@cavasinf not sure if you are still using this bundle, but if you have some spare time, you might want to checkout this Tabler 1.4 branch

@cavasinf
Copy link
Collaborator

cavasinf commented Nov 18, 2025

Hey @kevinpapst, you mean the demo bundle? Because of course I use TablerBundle 😄
On our side, we’re already running Tabler 1.4 and everything seems flawless, except for the fg badge class (which you already seem to have fixed).

I honestly wish we could use components (badge) inside other components (button), because we end up patching the same code multiple times, and the main badge component is outdated: https://github.com/kevinpapst/TablerBundle/blob/main/templates/components/badge.html.twig.
But I know, it will be a BC break, so 2.0 😉

There are still a few issues, but they come from Tabler itself, not the bundle.
Looks good to me 👍

cavasinf
cavasinf previously approved these changes Nov 18, 2025
cavasinf

This comment was marked as duplicate.

cavasinf
cavasinf previously approved these changes Nov 18, 2025
Copy link
Collaborator

@cavasinf cavasinf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Being nitpicky, but it's needed 😄

@kevinpapst
Copy link
Owner Author

I am not yet ready, as the theme wizard stuff isn't working in this version.
But its fine locally. Need to cleanup and then push it later.

Thanks for your quick reaction 👍

@kevinpapst
Copy link
Owner Author

If you have suggestions about the badge component in the 1.4 branch, please add them:
kevinpapst/TablerBundle#230

People need to adapt their badge code anyway, otherwise most badges will be broken.

cavasinf and others added 2 commits November 19, 2025 17:36
Co-authored-by: CAVASIN Florian <florian@allsoftware.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants