-
Notifications
You must be signed in to change notification settings - Fork 4
Tabler 1.4 #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Tabler 1.4 #25
Conversation
|
@cavasinf not sure if you are still using this bundle, but if you have some spare time, you might want to checkout this Tabler 1.4 branch |
|
Hey @kevinpapst, you mean the demo bundle? Because of course I use TablerBundle 😄 I honestly wish we could use components (badge) inside other components (button), because we end up patching the same code multiple times, and the main badge component is outdated: https://github.com/kevinpapst/TablerBundle/blob/main/templates/components/badge.html.twig. There are still a few issues, but they come from Tabler itself, not the bundle. |
cavasinf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Being nitpicky, but it's needed 😄
|
I am not yet ready, as the theme wizard stuff isn't working in this version. Thanks for your quick reaction 👍 |
|
If you have suggestions about the People need to adapt their badge code anyway, otherwise most badges will be broken. |
Co-authored-by: CAVASIN Florian <florian@allsoftware.fr>
See kevinpapst/TablerBundle#230