Add method for topological sorting#12
Open
fsobanski wants to merge 22 commits intokevinrutherford:masterfrom
Open
Add method for topological sorting#12fsobanski wants to merge 22 commits intokevinrutherford:masterfrom
fsobanski wants to merge 22 commits intokevinrutherford:masterfrom
Conversation
Author
|
Would you consider accepting this PR? It's basically just an implementation of this algorithm. |
Owner
|
Sorry, I don't have time to maintain that code these days (I haven't used
it myself for several years).
Feel free to use the code as the basis for your own gem, however.
Best regards,
Kevin
…On Mon, Jan 15, 2018 at 11:54 PM, fsobanski ***@***.***> wrote:
Would you consider accepting this PR? It's basically just an
implementation of this
<https://en.wikipedia.org/wiki/Topological_sorting#Depth-first_search>
algorithm.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#12 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABa-iRqwvYXhhFmvu5Kq3x_MSu-ZuNXks5tK-U5gaJpZM4RLu0Q>
.
--
*Kevin Rutherford*
+44 7973 563521
<+44%207973%20563521>
http://rutherford-software.com <http://xpsurgery.com>
|
added 21 commits
January 16, 2018 19:25
Support of ruby 1.9 and 2.1 has ended: https://www.ruby-lang.org/en/news/2017/04/01/support-of-ruby-2-1-has-ended/ Support of Rubinius 2 (rbx-2) has also ended: rubinius/rubinius#3717 (comment)
Used Rubocop with default settings as provided by the atom ide.
See https://github.com/bbatsov/ruby-style-guide#naming "Avoid prefixing predicate methods with the auxiliary verbs such as is, does, or can. These words are redundant and inconsistent with the style of boolean methods in the Ruby core library, such as empty? and include?."
I don't support backwards compatibility.
I don't support backwards compatibility.
See https://github.com/bbatsov/ruby-style-guide#naming "Avoid prefixing predicate methods with the auxiliary verbs such as is, does, or can. These words are redundant and inconsistent with the style of boolean methods in the Ruby core library, such as empty? and include?."
Subgraph test should also cover ancestors and descendants more than one step away.
The commit broke the travis build for some reason. This reverts commit 5cc4d5f.
This is not a multigraph.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.