Fix caching takes place in multi-site if plugin is activated on one s…#347
Open
8ctopus wants to merge 2 commits intokeycdn:masterfrom
Open
Fix caching takes place in multi-site if plugin is activated on one s…#3478ctopus wants to merge 2 commits intokeycdn:masterfrom
8ctopus wants to merge 2 commits intokeycdn:masterfrom
Conversation
…ite and disabled on another one that is a subfolder of the first one
Contributor
|
I can confirm this clean & simple change works on my local multisite install. Maybe add an |
Author
|
@futtta Thank you for testing it. What would |
Contributor
|
It would make sure to limit the behavior to multisite, where the actual problem occurs? |
Author
|
@futtta correct me if I'm wrong, my understanding is that this code is only executed on single-site if the plugin is enabled, therefore not strictly necessary. |
…as not yet loaded
Author
|
I had to move the code because otherwise the page was never delivered from cache if Apache was not delivering the cache. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix caching takes place in multi-site if plugin is activated on one site and disabled on another one that is a subfolder of the first one
Proposed fix for #343