Update reqwest-retry to 0.8, retry-policies to 0.5 #1165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
musicinmybrain
force-pushed
the
reqwest-retry0.8
branch
from
8eda419 to
ce1613d
Compare
Signed-off-by: Benjamin A. Beasley <code@musicinmybrain.net>
musicinmybrain
force-pushed
the
reqwest-retry0.8
branch
from
ce1613d to
0885fc0
Compare
Author
|
(Regarding availability of these versions downstream in Fedora, that’s the motivation for this PR: I have updated them with compat packages, and would like to work toward retiring the compat packages in Rawhide. See also https://src.fedoraproject.org/rpms/keylime-agent-rust/pull-request/45.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The breaking change in
retry-polices0.5 was thatbuild_with_total_retry_duration_and_max_retrieswas renamed tobuild_with_total_retry_duration_and_limit_retries. Sincerust-keylimedoesn’t use this function, no source-code changes are required.https://github.com/TrueLayer/retry-policies/blob/v0.5.1/CHANGELOG.md
The SemVer break in
reqwest-retryis simply because it re-exportsretry-policies.https://github.com/TrueLayer/reqwest-middleware/blob/1485f61e20c8cd31cabb663788f06206c19cabaf/reqwest-retry/CHANGELOG.md