Task #2 (based on actually development branch)#21
Open
iFrozenbyte wants to merge 2 commits intodevelopmentfrom
Open
Task #2 (based on actually development branch)#21iFrozenbyte wants to merge 2 commits intodevelopmentfrom
iFrozenbyte wants to merge 2 commits intodevelopmentfrom
Conversation
SKuznet
requested changes
Jun 16, 2019
|
|
||
| public class SecurityInit extends AbstractSecurityWebApplicationInitializer { | ||
| } | ||
|
|
| } | ||
|
|
||
| @RequestMapping("/") | ||
| @RequestMapping("/getCat") |
Collaborator
There was a problem hiding this comment.
this is not your functional - shoudn't change localhost:8080/ - for cat - localhost:8080/getCat
localhost:8080/getRole
solid -
|
|
||
| @Controller | ||
| @RequestMapping("/role") | ||
| // localhost:8080/role |
| import java.util.List; | ||
|
|
||
| public interface RoleService { | ||
| Role add(Role role); |
| hibernate.dialect=org.hibernate.dialect.PostgreSQLDialect | ||
| hibernate.show_sql=true | ||
| hibernate.format_sql=true | ||
| hibernate.hbm2ddl.auto=update No newline at end of file |
| private static final String ALL = "/all"; | ||
|
|
||
| @Test | ||
| public void checkAddRole(){ |
Collaborator
There was a problem hiding this comment.
you need add tests for all public api methods
| public class RoleController { | ||
| private RoleService roleService; | ||
|
|
||
| @RequestMapping(value = "/add", method = RequestMethod.POST, produces = "application/json;charset=utf-8") |
Collaborator
There was a problem hiding this comment.
add please update, delete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add rest layer for Role (added REST + Integration Test) into actually development branch.