update scraper to refelct website changes march 2022#6
Open
haydnjm wants to merge 1 commit intokhpeek:masterfrom
Open
update scraper to refelct website changes march 2022#6haydnjm wants to merge 1 commit intokhpeek:masterfrom
haydnjm wants to merge 1 commit intokhpeek:masterfrom
Conversation
|
Thank you for fixing it, but you've hardcoded the place argument in funda_spider.py line 11+12. |
| self.start_urls = ["http://www.funda.nl/koop/%s/p%s/" % (place, page_number) for page_number in range(1,301)] | ||
| self.base_url = "http://www.funda.nl/koop/%s/" % place | ||
| self.le1 = LinkExtractor(allow=r'%s+(huis|appartement)-\d{8}' % self.base_url) | ||
| start_urls = ["https://www.funda.nl/koop/amsterdam/p%s/" % (page_number) for page_number in range(500)] |
There was a problem hiding this comment.
Suggested change
| start_urls = ["https://www.funda.nl/koop/amsterdam/p%s/" % (page_number) for page_number in range(500)] | |
| def __init__(self, place= 'amsterdam') -> None: | |
| self.start_urls = [f"https://www.funda.nl/koop/{place}/p{page_number}/" for page_number in range(500)] | |
| self.base_url = f"https://www.funda.nl/koop/{place}/" | |
| self.le1 = LinkExtractor(allow=r'%s+(huis|appartement)-\d{8}' % self.base_url) |
replace % string with f-string and make place a variable again.
This should still work
Closed
nosperantos
approved these changes
Jul 21, 2022
nosperantos
approved these changes
Jul 21, 2022
jellevankerk
approved these changes
Sep 11, 2022
rcoenen
approved these changes
Oct 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran the scraper and there were a few things that weren't working any more because the website has changed (and also maybe because of the version of scrapy)
These changes fix it so that it works for almost all houses. There are a couple of exceptions but for what I was using it there wasn't much need fix all of the exception cases. Hope this helps!