Merged
Conversation
- Moved CSS styles from _logs_table.html.erb, _nodes_table.html.erb, _official_plugins.html.erb, index.html.erb, and _form.html.erb into kpm.css for better maintainability. - Updated the structure of the index.html.erb and plugins/index.html.erb to use new class names for styling consistency. - Cleaned up unnecessary inline styles and improved the organization of CSS rules.
Sync with master
New UI implementation for KPM page
Enhance plugins table: enable ordering and define column orderability
Remove unused CSS styles for table header indicators in nodes info index
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the KPM (Kill Bill Package Manager) plugin UI with a complete redesign. The changes focus on improving the visual appearance, user experience, and code organization.
- Replaced Rails.logger with Logger.new($stdout) in the client library for better standalone compatibility
- Redesigned plugin management interface with tabbed navigation and updated styling
- Added placeholder components for standalone gem usage (breadcrumb, button, sidebar)
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| lib/kpm/client.rb | Updated logger from Rails.logger to Logger.new($stdout) for standalone compatibility |
| app/views/kpm/plugins/index.html.erb | Redesigned plugin listing page with new layout and styling |
| app/views/kpm/plugins/_plugins_table.html.erb | Updated table styling and replaced icon with text link |
| app/views/kpm/plugins/_form.html.erb | Enhanced form layout with improved styling and Close/Install buttons |
| app/views/kpm/nodes_info/index.html.erb | Added tabbed navigation and updated JavaScript for plugin management |
| app/views/kpm/nodes_info/_official_plugins.html.erb | New partial for displaying official plugins with dropdown menus |
| app/views/kpm/nodes_info/_nodes_table.html.erb | Converted table to card-based layout with improved information display |
| app/views/kpm/nodes_info/_logs_table.html.erb | Updated logs table styling and search button |
| app/views/kaui/layouts/kaui_setting_sidebar.html.erb | Added placeholder for standalone gem usage |
| app/views/kaui/components/button/_button.html.erb | Added placeholder button component |
| app/views/kaui/components/breadcrumb/_breadcrumb.html.erb | Added placeholder breadcrumb component |
| app/assets/stylesheets/kpm/kpm.css | Added extensive CSS for new UI components and layouts |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Refactor dependencies display in nodes table for improved readability
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Admin UI