Skip to content

Remove loading icon when install new plugin #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pierre merged 2 commits into from
Jan 25, 2026
Merged

Remove loading icon when install new plugin #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01b7f20
Remove loading icon when install new plugin
tungleduyxyz Jan 12, 2026
5c35d59
Fix issue with mini test version
tungleduyxyz Jan 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ source 'https://rubygems.org'
# development dependencies will be added by default to the :development group.
gemspec

# Lock minitest to 5.x until Rails 7.1+ adds Minitest 6.0 support
# Minitest 6.0.0 was released Dec 2024 with breaking API changes
gem 'minitest', '~> 5.0'

# Declare any dependencies that are still in development here instead of in
# your gemspec. These might include edge Rails or gems from your path or
# Git. Remember to move these dependencies to your gemspec before releasing
Expand Down
2 changes: 0 additions & 2 deletions app/views/kpm/nodes_info/index.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,6 @@
$('#nodes-table-wrapper').css({ opacity: 0.5 });
$('#install-in-progress').show();
$('#install-in-progress').children().addClass('fa-spin');
$('.plugin-link').addClass('loading');
$('.official-plugin').addClass('loading');
setTimeout(fakeOperationComplete, 6000);
<% end %>

Expand Down
Loading