Skip to content

New functions to get the masses and semimajor axes of companions accurately #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cevawm wants to merge 24 commits into
base: main
Choose a base branch
from
Open

New functions to get the masses and semimajor axes of companions accurately #56

Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
7b88c9c
New function get_planet_mass_accurate to get the actual mass of a com…
cevawm Feb 3, 2026
67e56b0
New function works for single prim mass values, but not mu +/- std tu…
cevawm Feb 3, 2026
cd883e3
Try calculating accurate companion mass with full posteriors (fail)
cevawm Feb 3, 2026
2df7ac7
Calculate accurate companion mass with full posteriors via for loops …
cevawm Feb 3, 2026
ddd5dfc
Found vectorized approach to calculate companion mass with full poste…
cevawm Feb 4, 2026
4c53228
Fix issue with unreal solutions by stating constants are always positive
cevawm Feb 4, 2026
0647827
Move companion mass equation solution to top of function
cevawm Feb 4, 2026
c9fc5c9
get_planet_mass_accurate now working for all single companion calcula…
cevawm Feb 4, 2026
5a243c1
Move sine into numerator to avoid divide by zero err when i is 0
cevawm Feb 4, 2026
7c1bd78
Iteratively calculate outer companion masses by including inner compa…
cevawm Feb 5, 2026
67db58d
Try to change equation to avoid divide by zero error (does not work)
cevawm Feb 5, 2026
1f32bf8
Switch to sympy predicate nonnegative to try to avoid divide by zero …
cevawm Feb 5, 2026
242d18e
Change equation and switch to sympy predicate nonnegative to avoid di…
cevawm Feb 5, 2026
1cbb19b
Original get_planet_mass function also had divide by zero issue - ign…
cevawm Feb 5, 2026
56ff16a
New functions to get accurate companion semimajor axis (partially tes…
cevawm Feb 5, 2026
2ca108d
Change meaning of full_output for new comp mass func and account for …
cevawm Feb 5, 2026
8af7df8
New functions to get accurate comp mass and SMA values are now (basic…
cevawm Feb 5, 2026
9fbbf88
Merge branch 'kima-org:main' into comp_mass_sma_funct
cevawm Feb 5, 2026
e7d9263
Add companion mass error in error propagation for new sma calculation
cevawm Feb 6, 2026
3f9703b
Bug tests and fixes (now works in all parameter combinations)
cevawm Feb 6, 2026
9a14d07
Switch numerator/denominator of comp mass equation (to always ensure …
cevawm Feb 6, 2026
0e51545
Apply PEP 8 conventions using VSCode plugin
cevawm Feb 6, 2026
e051bf9
Add option to just get msini from new mass and sma functions
cevawm Mar 6, 2026
7bdcf83
Fix inclination argument bug
cevawm Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading