Skip to content

Conversation

@kimden
Copy link
Owner

@kimden kimden commented Aug 21, 2025

(so small that I make a separate PR for it)

I just wanted to restructure external commands but suddenly wished to combine a newly created AbstractResource class with existing Command class...

As a result I expect:

  • Command implementations to not be member methods of CommandManager
  • MapFileResource implemented (the original goal)
  • Slight refactor with fresh eyes and more experience than in 2021 when I wrote that

(Regarding the first point, technically, 3 implementations depend on CommandManager, but the required things from it will later be moved to Context. The rest of them don't use CM, can be separated from it, but right now there's no need to move them elsewhere).

Agreement

By creating a pull request in stk-code, you hereby agree to dual-license your contribution as
GNU General Public License version 3 or any later version and
Mozilla Public License version 2 or any later version.

This includes your previous contribution(s) under the same name of contributor.

Keep the above statement in the pull request comment for agreement.

@kimden
Copy link
Owner Author

kimden commented Aug 30, 2025

Tested before the last posted commit (which doesn't change a lot), seems to work fine.

@kimden kimden merged commit af4ae1a into master Aug 30, 2025
24 of 25 checks passed
@kimden kimden deleted the 250822-slight-cm-refactor branch August 30, 2025 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants