Skip to content

Enabled channels can be now loaded also using a remote json #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
H7-25 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Enabled channels can be now loaded also using a remote json #40

H7-25 wants to merge 3 commits into from

Conversation

@H7-25
Copy link

@H7-25 H7-25 commented Jun 28, 2019

Now enabled channels can be loaded using a remote json.

@prawnsalad
Copy link
Member

prawnsalad commented Jun 28, 2019

Hm I think this enabledInChannels variable is actually badly named. Are you expecting it to only allow the channels listed in it to use the conference plugin? At the moment it's only used to control if the conference call sends a message to the channel, nothing else.

filippo nicola cortigiani added 2 commits July 1, 2019 10:46
Renamed enabledInChannels var to enabledNotifyInChannels wich better …
080aab3 
…specify its role.

Var enabledInChannels now define an array of channels allowed to have public conference enabled.
renamed enabledInChannelsJsonUrl to enabledInChannelsJson
a151280 
if enabledInChannelsJson url is nost specified in config.json than enabledInChannels setting is used
@ojamin ojamin requested a review from prawnsalad July 19, 2019 22:48
@ojamin ojamin added the enhancement New feature or request label Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@prawnsalad prawnsalad Awaiting requested review from prawnsalad

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@H7-25 @prawnsalad @ojamin