Skip to content

Conversation

@ItsOnlyBinary
Copy link
Contributor

current implementation requires a specific plugin name in config.json, this makes it a little more forgiving as it also attempts to use the url to find its self

@prawnsalad
Copy link
Member

I think this issue is more rooted in that plugin configuration can be a little awkward at the moment. We should think about having a different plugin structure in kiwiirc core so that each plugin has its own config object passed to it directly

@ItsOnlyBinary
Copy link
Contributor Author

Its the way the preloader finds its location so it can load the full plugin, it relies on plugin name in the config for its url

i was going to pass the plugin name to the plugin constructor function but it appears the preloader doesnt use it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants