Open
Conversation
kkrismer
reviewed
Mar 7, 2025
| <inherited>false</inherited> | ||
| <configuration> | ||
| <launcherDir>${project.build.directory}/gwt/launcherDir</launcherDir> | ||
| <moduleName/> |
Owner
There was a problem hiding this comment.
Wow, this is all it took? As far as I remember they introduced this modules business already in Java 9?
Owner
There was a problem hiding this comment.
Also, this probably also works with Java 11?
So I guess the order of things would be:
- Land this PR
- Deploy Scansite
- Upgrade Java 11 to Java 21 on the server
Collaborator
Author
There was a problem hiding this comment.
Is the deploy_from_git.sh the current script for deploying scansite? I think now would be a good time to deploy in case something does not work at the first try.
Also, do you approve this because the kinase-library won't work with Java21 because of the outdated Lombok version?
Owner
There was a problem hiding this comment.
deploy_from_git.sh is outdated. Scansite deployment is currently unfortunately a manual process. I'll describe on Slack.
kkrismer
approved these changes
Mar 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.