update for qmk 1.1.1 or later #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
optozorax
requested changes
Feb 25, 2023
Collaborator
optozorax
left a comment
optozorax
left a comment
There was a problem hiding this comment.
В целом всё ок, нужно только поправить эти замечания и можно мерджить
| register_code(KC_LSHIFT); | ||
| } | ||
| } break; | ||
| case LANG_CHANGE_SHIFT_ALT: { |
Collaborator
There was a problem hiding this comment.
почему эта клавиша удалена?
| register_code(KC_LSHIFT); | ||
| } | ||
| } break; | ||
| case LANG_CHANGE_SHIFT_CTRL: { |
Collaborator
There was a problem hiding this comment.
И почему эта тоже удалена?
| lang_current = lang; | ||
| } | ||
|
|
||
| void lang_toggle(int externalLang) { |
Collaborator
There was a problem hiding this comment.
Кажется это не очень относится к данному ревью, и если это фикс чего-то, то это должно идти отдельным ревью
| lang_current_change = LANG_CHANGE_ALT_SHIFT; | ||
| } | ||
| return false; | ||
| case LA_SHAL: |
Collaborator
There was a problem hiding this comment.
тоже зачем удалять эту клавишу?
| lang_current_change = LANG_CHANGE_CTRL_SHIFT; | ||
| } | ||
| return false; | ||
| case LA_SHCT: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Модуль не работает в текущей версии qmk 1.1.1 из-за изменений названий кейкодов, в этой ветке внесены правки для корректной работы.