Fix #62 Optional path argument in JoinMapper#65
Open
a4tunado wants to merge 5 commits intoklbostee:masterfrom
Open
Fix #62 Optional path argument in JoinMapper#65a4tunado wants to merge 5 commits intoklbostee:masterfrom
a4tunado wants to merge 5 commits intoklbostee:masterfrom
Conversation
Owner
|
Sounds good! Will try to find some time to review and merge this soonish. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now to get source path from the mapper routine just add **kwargs to the arguments list. Here are some examples.
Or you can specify desired argument directly
Callable instances are also supported
And previous mapper interface is working aswell
This approach allows easily extend interface to pass other arguments in the future