Fix missing texturecache log on Windows #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thanks for the continuation of script.database.cleaner and integrating texturecache.py.
I had a problem where the cleaner log would only show normal output and not from texturecache.py. It only occurred on Windows and not on Linux (Vero4k/OSMC).
Problem occurs with these settings:
Cause:
create_log_file gets called twice when reaching the cleaning stage. The second call opens a second handle on the already opened (or "not-closed") database-cleaner.log. Linux is apparently fine with this but Windows isn't. By the time texturecache.py wants to write to the global_logfile handle, it cannot.
Solution:
fixed it by using a better way to deal with files (resources are always properly closed/cleaned).