Set sidecar.istio.io/inject as label instead of annotation

[folliehiyuki]

Description

It seems the fix was made for the other Knative-related repos, but not this one.

Changes

• Set sidecar.istio.io/inject=true as Label instead of Annotation
• Also fix TestDeleteProfileFlag test case since it should reference the test profile defined within the function instead of the annotation from Istio profile

Reference

Fixes #1969

https://istio.io/latest/docs/reference/config/annotations/#SidecarInject

[linux-foundation-easycla]

• ❌ - login: @folliehiyuki / name: Hoang Nguyen . The commit (2e97f64) is not authorized under a signed CLA. Please click here to be authorized. For further assistance with EasyCLA, please submit a support request ticket.

[knative-prow]

Welcome @folliehiyuki! It looks like this is your first PR to knative/client 🎉

[knative-prow]

Hi @folliehiyuki. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[dprotaso]

/lgtm
/approve

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, folliehiyuki

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [dprotaso]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[knative-prow]

@folliehiyuki: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
build-tests_client_main	2e97f64	link	true	/test build-tests

Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[dprotaso]

You'll have to sign the CLA and fix the build issues the PR introduces