feat: support default values in tls.NewConfigFromEnv#3327
feat: support default values in tls.NewConfigFromEnv#3327Fedosin wants to merge 1 commit intoknative:mainfrom
Conversation
Add a DefaultMinTLSVersion constant (TLS 1.3) and an optional defaults parameter to NewConfigFromEnv so callers can supply fallback values for fields not set by environment variables. The webhook package now passes DefaultMinTLSVersion through the new parameter, simplifying its TLS setup logic. Signed-off-by: Mikhail Fedosin <mfedosin@redhat.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Fedosin The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/hold |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3327 +/- ##
=======================================
Coverage 74.87% 74.88%
=======================================
Files 189 189
Lines 8299 8302 +3
=======================================
+ Hits 6214 6217 +3
Misses 1844 1844
Partials 241 241 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Changes
Add a DefaultMinTLSVersion constant (TLS 1.3) and an optional defaults parameter to NewConfigFromEnv so callers can supply fallback values for fields not set by environment variables. The webhook package now passes DefaultMinTLSVersion through the new parameter, simplifying its TLS setup logic.
/kind enhancement
Fixes #
Release Note
Docs