Skip to content

feat: support default values in tls.NewConfigFromEnv#3327

Closed
Fedosin wants to merge 1 commit intoknative:mainfrom
Fedosin:tls-opts-defaults
Closed

feat: support default values in tls.NewConfigFromEnv#3327
Fedosin wants to merge 1 commit intoknative:mainfrom
Fedosin:tls-opts-defaults

Conversation

@Fedosin
Copy link
Contributor

@Fedosin Fedosin commented Mar 3, 2026

Changes

Add a DefaultMinTLSVersion constant (TLS 1.3) and an optional defaults parameter to NewConfigFromEnv so callers can supply fallback values for fields not set by environment variables. The webhook package now passes DefaultMinTLSVersion through the new parameter, simplifying its TLS setup logic.

/kind enhancement

Fixes #

Release Note

tls.NewConfigFromEnv now accepts an optional defaults Config, letting callers supply fallback values for any field not set by an environment variable. A new DefaultMinTLSVersion constant (TLS 1.3) is exported for convenience. The webhook package uses this to simplify its TLS setup.

Docs


Add a DefaultMinTLSVersion constant (TLS 1.3) and an optional defaults
parameter to NewConfigFromEnv so callers can supply fallback values for
fields not set by environment variables. The webhook package now passes
DefaultMinTLSVersion through the new parameter, simplifying its TLS
setup logic.

Signed-off-by: Mikhail Fedosin <mfedosin@redhat.com>
@knative-prow knative-prow bot added kind/enhancement size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 3, 2026
@knative-prow
Copy link

knative-prow bot commented Mar 3, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Fedosin
Once this PR has been reviewed and has the lgtm label, please assign leo6leo for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Fedosin
Copy link
Contributor Author

Fedosin commented Mar 3, 2026

/hold

@knative-prow knative-prow bot requested review from creydr and skonto March 3, 2026 17:12
@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 3, 2026
@codecov
Copy link

codecov bot commented Mar 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.88%. Comparing base (1f39e94) to head (76dbbdd).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3327   +/-   ##
=======================================
  Coverage   74.87%   74.88%           
=======================================
  Files         189      189           
  Lines        8299     8302    +3     
=======================================
+ Hits         6214     6217    +3     
  Misses       1844     1844           
  Partials      241      241           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 4, 2026
@knative-prow-robot
Copy link
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Fedosin Fedosin closed this Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/enhancement needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants