Chore/#1 storybook 및 chromatic 배포 설정 #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
1 task
There was a problem hiding this comment.
Pull Request Overview
This PR sets up Storybook for component development and configures Chromatic deployment for visual testing, while also simplifying the pre-commit process by replacing lint-staged with direct pnpm lint execution.
- Sets up Storybook with default components (Button, Header, Page) and configuration
- Configures Chromatic deployment workflow for automated visual testing on pull requests
- Simplifies pre-commit hooks by removing lint-staged dependency and using pnpm lint directly
Reviewed Changes
Copilot reviewed 21 out of 44 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Removes lint-staged configuration and dependency |
| lint-staged.config.js | Completely removes lint-staged configuration file |
| lefthook.yml | Updates pre-commit to use pnpm lint instead of lint-staged |
| apps/storybook/* | Adds complete Storybook setup with stories, configuration, and build scripts |
| .github/workflows/deploy-chromatic.yml | Configures automated Chromatic deployment for visual testing |
Comments suppressed due to low confidence (1)
- GitHub Actions에 pnpm과 Node.js를 한 번에 설치하는 composite action을 도입 - Chromatic 워크플로에서 중복된 setup-node 단계를 제거하고 새 액션을 사용하도록 변경
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
📝작업 내용
스크린샷 (선택)
💬리뷰 요구사항(선택)