feat(mobile): full-viewport map with geolocation centering#942
Merged
Conversation
Make mobile map feel like Google Maps: full-viewport by default, auto-centered on user's precise location. - Add resolvePreciseUserCoordinates() that actively prompts geolocation - Fire geolocation in parallel with resolveUserRegion() to avoid blocking init - Default mobile map to expanded (first visit), respect localStorage collapse - CSS: 100dvh map height with safe-area-inset support + 100vh fallback - Add viewport-fit=cover for notched device support - E2E: geolocation centering + viewport height assertion tests
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
matthewvecchione1-ops
pushed a commit
to matthewvecchione1-ops/worldmonitor
that referenced
this pull request
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
100dvhwith safe-area insets,100vhfallback for older browsersviewport-fit=covermeta for notched device supportFiles Changed
src/utils/user-location.tsresolvePreciseUserCoordinates()helpersrc/App.tsinit(), apply coords post-map-creationsrc/app/panel-layout.tsnull→ expandedsrc/styles/main.css.map-section→ full-viewport with dvh + safe-areaindex.htmlviewport-fit=coveron viewport metae2e/mobile-map-native.spec.tsTest plan
npx tsc --noEmitpasses (verified — zero errors)?lat=40&lon=-74&zoom=5→ skips geolocation, uses URL coordsnpx playwright test e2e/mobile-map-native.spec.ts— new + existing tests pass