depends: Bump dlfcn-win32 to v1.4.2#148
Conversation
89ccec8 to
1dd5d77
Compare
There was a problem hiding this comment.
Pull request overview
This PR bumps the dlfcn-win32 dependency from v1.2.0 to v1.4.2 for both windows (desktop) and windowsstore (UWP) build targets. The upgrade brings CMake 4.0 compatibility (eliminating the need for the CMake policy patch) and adds Windows ARM64 support. For the UWP target, since the official v1.4.2 upstream release broke the Azure patch step, the author uses a personal fork (garbear/dlfcn-win32) with the UWP changes already committed at tag v1.4.2-uwp2, removing the need for the UWP patch file as well.
Changes:
- Updated dependency URLs and SHA256 hashes for both
windowsandwindowsstoretargets to v1.4.2. - Removed the now-unnecessary CMake policy bump patches for both targets (handled natively in v1.4.2); removed the UWP patch for
windowsstore(baked into the fork tag). - Updated
0001-dlopen_with_widechar.patchforwindowsto reflect the new source file path (src/dlfcn.c) and line numbers in v1.4.2; added a.gitattributesentry to prevent LF/CRLF corruption of patch files.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
depends/windows/dlfcn-win32/dlfcn-win32.txt |
Updated URL to official v1.4.2 release |
depends/windows/dlfcn-win32/dlfcn-win32.sha256 |
Updated SHA256 for v1.4.2 tarball |
depends/windows/dlfcn-win32/0001-dlopen_with_widechar.patch |
Rebased widechar patch onto v1.4.2 source layout (now at src/dlfcn.c, line ~415), added proper git patch header |
depends/windows/dlfcn-win32/0001-Bump-policy_max-in-cmake_minimum_required-to-3.10.patch |
Removed (CMake 4.0 now supported natively by v1.4.2) |
depends/windowsstore/dlfcn-win32/dlfcn-win32.txt |
Updated URL to forked v1.4.2-uwp2 tag |
depends/windowsstore/dlfcn-win32/dlfcn-win32.sha256 |
Updated SHA256 for UWP fork tarball |
depends/windowsstore/dlfcn-win32/0001-win10-fixed-uwp-build.patch |
Removed (UWP changes are now in the forked tag) |
depends/windowsstore/dlfcn-win32/0001-Bump-policy_max-in-cmake_minimum_required-to-3.10.patch |
Removed (CMake 4.0 support in v1.4.2) |
.gitattributes |
Added -text attributes for patch files to prevent line ending changes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
b4f901d to
dd84a84
Compare
|
OK, I dropped the personal repo, and modified the Azure pipeline to wrap |
dd84a84 to
931fe5c
Compare
Description
As title says, I bumped dlfcn-win32 to v1.4.2, and updated the patches.
Notable changes:
dlfcn-win32 fork
I rebased the windows UWP patch, but it crashes patch.exe on Azure, so I forked the dlfcn-win32 repo and tagged v1.4.2 with Alwin's commit.
Error on azure was:
Then in the depends file I set the repo to my fork + the commit:
How has this been tested?
Compile-tested on Windows 10 x64. Runtime testing in progress.
Other add-ons
The following add-ons also use dlfcn-win32 and should be updated: