Conversation
There was a problem hiding this comment.
Pull request overview
Fixes a VFS wrapper bug where file/stat flag bitmasks were being combined with &= instead of |=, causing required flags to never be set (which can prevent UAE from detecting BIOS files via stat/validity checks).
Changes:
- Use
|=(bitwise OR) to accumulate Kodi VFS open flags for read-only file opens. - Use
|=(bitwise OR) to accumulateretro_vfsstat result bitmask flags (IS_VALID,IS_DIRECTORY,IS_CHARACTER_SPECIAL).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
This PR fixes incorrect bitmask manipulation in the libretro VFS wrapper so that file open flags and stat() result flags are set correctly, addressing UAE failing to locate BIOS files.
Changes:
- Fix
OpenFile()to set Kodi VFS read flags with bitwise OR (|=) instead of AND (&=). - Fix
Stat()to setRETRO_VFS_STAT_*result flags with bitwise OR (|=) instead of AND (&=).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Reported working in the forum: https://forum.kodi.tv/showthread.php?tid=384979 |
Description
Fixes bug in the VFS wrapper causing UAE to not find BIOS files.
Motivation and context:
Reported here: https://forum.kodi.tv/showthread.php?tid=384979