Fix empty review handling during PR creation#77
Merged
Conversation
- treat empty review input as absent so pr_sync can create PRs - clarify create-only guidance to skip review-specific fields - cover the create path and pr/fix subtask behavior in tests
![kompassdev[bot]](https://avatars.githubusercontent.com/in/3075751?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
SKIPPED
Description
Prevent PR creation flows from being treated like review submissions when the caller passes an empty review object, so PR automation stays aligned with the intended create-only contract.
Checklist
PR Creation
reviewpayloads instead of requiring an existing PRCommand Contract
pr/createworkflow now tells callers to omit review-only fields during PR creationreviewandcommitIdCommand Config
pr/fixstays non-subtask in both CI and non-CI command config coverageValidation
pr_synccreation coverage includes the empty-review case