Conversation
![kompassdev[bot]](https://avatars.githubusercontent.com/in/3075751?s=60&v=4){kind=small}
There was a problem hiding this comment.
★★☆☆☆
DEMO.md contains placeholder text that should not be merged into the main branch. The content provides no documentation value. If this PR is meant to document the demo branch, DEMO.md should contain actual useful documentation. If DEMO.md was created for demo purposes only (like the removed index.ts comments), it should be removed from this PR before merging.
| @@ -0,0 +1 @@ | |||
| This is a file i'm using in the demo. GOOD STUFF. | |||
There was a problem hiding this comment.
This placeholder content ("This is a file i'm using in the demo. GOOD STUFF.") should not be merged into main. Either:
- Remove DEMO.md entirely (if it's demo-only content), or
- Replace with actual documentation about the demo branch
The prior reviews flagged demo-only comments in packages/opencode/index.ts, which were correctly removed. DEMO.md appears to be the same category of demo-only content.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reply to addressed PR review comments after removing demo-only comments from packages/opencode/index.ts.