Conversation
Summary of ChangesHello @RaptBliss, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 이 PR은 Mandu 프로젝트의 데이터 패칭 및 캐싱 전략을 표준화하기 위한 Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
이 PR은 @mandujs/query 도입을 위한 잘 구조화되고 포괄적인 기획서를 추가합니다. TanStack Query 위에 얇은 래퍼를 만드는 전략은 Mandu 프로젝트 내 표준화를 이루면서도 업스트림 생태계를 활용하는 좋은 접근 방식입니다. 문서는 배경, 목표, API 설계, 그리고 출시 계획을 명확하게 설명하고 있습니다. API 설계와 기본 동작을 더욱 명확히 하여 기획의 완성도를 높일 수 있는 몇 가지 사소한 제안을 리뷰 코멘트에 남겼습니다. 전반적으로 개발을 효과적으로 이끌어줄 훌륭한 기획 문서입니다.
| - `getRouteQueryKey(routeId, params?, scope?)` | ||
| - route 기반 key 생성 표준 |
|
|
||
| - staleTime: 15s | ||
| - gcTime: 5m | ||
| - retry: 1~2회 (idempotent query만) |
There was a problem hiding this comment.
d263422 to
ff13514
Compare
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
요약
docs/plans/16_mandu_query_wrapper_plan.md포함 내용
ManduQueryProvider, route key helper, SSR hydrate/dehydrate, SSE invalidation)기대 효과