Skip to content

Conversation

@benoit-pierre
Copy link
Member

@benoit-pierre benoit-pierre commented Sep 12, 2025

Cf. koreader/koreader#1517 (comment).


This change is Reviewable

@gd4c
Copy link

gd4c commented Sep 12, 2025

I think there is also:

<data android:mimeType="application/x-cbr"/>
<data android:pathPattern=".*\\.cbr"/>

somewhere in the manifest

@benoit-pierre
Copy link
Member Author

benoit-pierre commented Sep 12, 2025

application/x-cbz and the like are deprecated (cf. https://www.iana.org/assignments/media-types/application/vnd.comicbook-rar).

@Frenzie
Copy link
Member

Frenzie commented Sep 12, 2025

That doesn't necessarily matter if it's in active use. :-) (I'm not saying it is or isn't.)

@Frenzie Frenzie merged commit d676dd6 into koreader:master Sep 12, 2025
3 checks passed
@benoit-pierre benoit-pierre deleted the pr/add_cbr_mime-types branch September 16, 2025 15:41
benoit-pierre added a commit to benoit-pierre/koreader that referenced this pull request Dec 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants