Skip to content

Conversation

@mprokopov
Copy link

Allows specify extra parameters for mysql jdbc driver in map under key :extra

example:

(def db-params (mysql {:host "localhost"
                   :db "itservice"
                   :user "root"
                   :extra {:useLegacyDatetimeCode false
                           :serverTimezone "UTC"
                           :useSSL false}}))

this appends "?useLegacyDatetimeCode&serverTimezone=UTC&useSSL=false" to subname

@jiacai2050
Copy link

Is there anyone looking into this ?

@venantius
Copy link
Contributor

In general this approach seems fine, but it needs tests before we'll be able to consider merging it.

@@ -1,4 +1,4 @@
(defproject korma "0.4.3"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't change the project name.

@venantius venantius added the triaged-pr This PR has received at least an initial review label Feb 27, 2018
@zjjfly
Copy link

zjjfly commented Jun 1, 2018

though we can specify extra parameters in :db,this pr offers much better clearity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

triaged-pr This PR has received at least an initial review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants