Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a comprehensive Docling validation benchmark harness under
backend/paperchat/benchmarks/docling_validation/. It provides a CLI for running document conversion and chunking benchmarks, data models for fixtures and results, manifest loading utilities, a retrieval scoring module, and an adapter for interfacing with the Docling library. It also adds a small exclusion to the pre-commit config and a module docstring.Docling validation harness and CLI:
cli.py) to run the Docling validation benchmark, supporting arguments for fixtures, queries, output directory, and top-k metrics.__init__.pyand a module-level docstring for the benchmark tooling. [1] [2]Core logic and integration with Docling:
docling_adapter.py, which loads Docling components, runs document conversion and chunking, normalizes chunk data, and handles warnings/errors robustly.Data models and manifest handling:
models.pyfor fixture documents, queries, chunking results, summaries, and recommendations, ensuring type safety and clarity.manifests.pyto load and validate fixture and query manifests from JSON files, with error handling for missing or malformed data.Retrieval and scoring utilities:
retrieval.pyto tokenize text, compute term frequencies, cosine similarity, and rank chunks for retrieval evaluation.Tooling and configuration:
.pre-commit-config.yamlto exclude large PDF files in test fixtures from pre-commit checks.