-
Notifications
You must be signed in to change notification settings - Fork 241
Align API types between Porch and kpt #4341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for kptdocs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
prob need a docs update to go with this right? |
When we bring in the "upgrade" we'll have to completely revisit the documentation in kpt. Today kpt is still on "update" but in porch we have replaced that with "upgrade", so when we make that port, we should update the docs. We may also port some of the documentation done on Porch to kpt for that area. |
This PR aligns the kpt api types in Porch and kpt.
The only difference in the types is that the "copy-merge" update strategy in Porch does not exist in kpt. This PR adds that strategy to kpt. The copy-merge strategy uses a new
RemoveStaleItemsutility function, which is included in this PR as well.Whne this PR is merged, the kpt API types can be used directly in Porch, allowing the cloned types in Porch to be deleted. Further, this will allow duplicate code in Porch to be removed bit by bit.