Skip to content

update the unused 'doc' variable to be assigned to docs allowing the …#12

Open
robhitt wants to merge 1 commit intokrishnaik06:mainfrom
robhitt:main
Open

update the unused 'doc' variable to be assigned to docs allowing the …#12
robhitt wants to merge 1 commit intokrishnaik06:mainfrom
robhitt:main

Conversation

@robhitt
Copy link

@robhitt robhitt commented Mar 28, 2024

In LLM Generic APP > test.ipynb in the method chunk_data it is currently returning docs and should return doc. In its current form, doc is an unused variable.

Currently this function doesn't do anything other than pass through the original docs argument .

See below where doc is currently being unused:

def chunk_data(docs,chunk_size=800,chunk_overlap=50):
    text_splitter=RecursiveCharacterTextSplitter(chunk_size=chunk_size,chunk_overlap=chunk_overlap)
    doc=text_splitter.split_documents(docs)  # <-- doc unused
    return docs  # <-- returning initial docs argument

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant